Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed black border around icon #72

Open
wants to merge 750 commits into
base: master
Choose a base branch
from
Open

removed black border around icon #72

wants to merge 750 commits into from

Conversation

I3ck
Copy link

@I3ck I3ck commented May 12, 2015

No description provided.

thialfihar and others added 30 commits April 9, 2014 16:35
- moved all specific Public/Secret logic from the Adapter class into
  inner subclasses in the Fragments
- more versatile status display ("revoked", "expired", "can certify"...)
- applied view holder pattern
- query logic, including subqueries, moved into provider classes

Closes #375
thialfihar and others added 28 commits May 14, 2014 12:00
It isn't a key capability like certify, encrypt, sign,
and it's redundant, since the key is crossed out.
This allows any KeyServer to store some extra data it might need.
In the case of KeybaseKeyServer it is the username, which then can
be grabbed directly, without the hack of storing it as userId.
Once keybase reports them, we can display them. Until then we simply
don't know and shouldn't lie about it.
Remove ctime and the cached key, making the query for the entire user
object unnecessary. This should only be done when the user decides to
import the key. Hopefully keybase.io can provide all info necessary in
the search results.
The very point of keybase.io is the identification and proven link
to those identities, so it should be nice to have them.
The display is a bit basic still, as it just adds them as userIds,
I'm sure this can be prettified, perhaps with logos?
For the regex matching it would be smart to sort the words by length,
so the longest matches come first. This only matters for queries with
words containing parts of each other, which is an unlikely event and
even then it doesn't break anything.
@thialfihar thialfihar force-pushed the master branch 2 times, most recently from e336239 to 037db3b Compare June 25, 2015 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants